Conversation
Collaborator
Author
|
I've been looking into removing
The first one seems not too hard to avoid, but the second seems more essential. I got rid of other uses by pushing normalization to the translation phase (MIR -> FMIR and Pearlite THIR -> Term), although it feels rather fragile... The tests pass but I wouldn't be surprised if there are still terms containing unnormalized or unerased types that we just happen to not look at. |
Lysxia
force-pushed
the
nightly-2026-04
branch
2 times, most recently
from
177a3dd to
6680faa
Compare
Collaborator
Author
|
I think I'm about done cleaning up the normalizes for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instantiatewraps its result inUnnormalized<_>so this is a good opportunity to revisit how we handle normalizationDefKind::ConstandAssocConstnow carry a boolean to keep track of whether they are "suitable for generics", if I understand correctly. I don't think it affects us (hence this PR just ignores that boolean), but while looking into it I learned that people working on const generics have at least thought about having a termination checker to enable more powerful const generics: https://hackmd.io/OsVAAEgOS2ajDwxg44kN-A?viewAtomicBoolhas become a synonym forAtomic<Bool>(etc.) which seems relevant to concurrency folks core: make atomic primitives type aliases ofAtomic<T>rust-lang/rust#153015